From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ethdev: revert use device name from device structure Date: Wed, 11 Oct 2017 23:56:54 +0200 Message-ID: <5659846.3hnuzHVyBs@xps> References: <20170922113007.43385-1-ferruh.yigit@intel.com> <20170922145722.GA3871@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Adrien Mazarguil , ktraynor@redhat.com, gaetan.rivet@6wind.com, jblunck@infradead.org To: Ferruh Yigit , ciara.loftus@intel.com Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E7E801B206 for ; Wed, 11 Oct 2017 23:56:56 +0200 (CEST) In-Reply-To: <20170922145722.GA3871@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/09/2017 16:57, Adrien Mazarguil: > On Fri, Sep 22, 2017 at 12:30:07PM +0100, Ferruh Yigit wrote: > > This reverts commit a1e7c17555e8f77d520ba5f06ed26c00e77a2bd1. > > > > Original commit assumes there is 1:1 mapping between physical device and > > ethdev port, so that device name can be used per port instead of ethdev > > name field. > > > > But one physical device may have multiple ethdev ports and each port > > needs its own unique name. > > > > One issue reported here: > > http://dpdk.org/ml/archives/users/2017-September/002484.html > > > > So reverting back the commit to continue using ethdev name field per > > port. > > > > Reported-by: Adrien Mazarguil > > Signed-off-by: Ferruh Yigit > > Acked-by: Adrien Mazarguil Acked-by: Thomas Monjalon I agree we must keep separate the device name and the ethdev port name. About the OVS issue (Cc'ing people), it would be valuable to work in DPDK to establish a reliable syntax to describe a device or a port. This is what we call devargs ; it is still a work in progress.