From mboxrd@z Thu Jan 1 00:00:00 1970 From: Panu Matilainen Subject: Re: [PATCH 03/10] mk: install a standard cutomizable tree Date: Wed, 2 Dec 2015 15:29:47 +0200 Message-ID: <565EF24B.2080507@redhat.com> References: <1449028676-19232-1-git-send-email-thomas.monjalon@6wind.com> <1789607.LxQySkSOJm@xps13> <565EEA08.9050900@redhat.com> <1767798.Go7fG5LFJB@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Thomas Monjalon Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 3887D5913 for ; Wed, 2 Dec 2015 14:29:50 +0100 (CET) In-Reply-To: <1767798.Go7fG5LFJB@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/02/2015 03:05 PM, Thomas Monjalon wrote: > 2015-12-02 14:54, Panu Matilainen: >> On 12/02/2015 01:25 PM, Thomas Monjalon wrote: >>> 2015-12-02 12:27, Panu Matilainen: >>>> $(prefix)/share is supposed to be shareable across different >>>> architectures. Most of the content here is, but at least the lib symlink >>>> and .config file are not. >>> >>> The case you want to address is multilib 32/x32/64, right? >> >> That, plus modern Debian/Ubuntu supports multiarch, not just -lib. > > We do not support completely different platforms (e.g. ARM and x86) > with only one include directory. At the moment, only variants (32/64) > live together. Actually even the variants will run into problems because eg rte_config.h will differ between 32- and 64-bit. But that's a problem for another day, this is hardly the most pressing of issues :) > >>>> One option is to install .config and the symlinks within $(sdkdir)/$(T) >>>> directories, then it can be shared across architectures because each >>>> lives in their own directory. Another possibility is moving the whole >>>> sdk directory into a subdir in $(libdir), but that misses the >>>> opportunity to share across architectures (whether anybody actually >>>> cares is a whole other question :) >>> >>> Yes, I tried to remove the use of RTE_TARGET when building an example. >>> But we can keep it with a subdirectory in $(sdkdir). >> >> Just realized my suggestion $(sdkdir)/$(T) would not cut it because if >> T= is specified then this installation method wont be invoked at all :D > > I don't understand what you mean. > In my patchset, the installation is the same (except some default values) > with and without T=. Hmm, must've misuderstood/mixed up with something Marios patches do. Never mind, I was just mumbling out loud anyhow. > >> So yeah, RTE_TARGET. Or perhaps just RTE_ARCH. Dunno if there's actual >> added value to having the whole target string there, but I wont mind either. > > RTE_TARGET is a safe choice for future. > Nod. - Panu -