From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: vmxnet3 driver - vlan offload is on end descriptor Date: Thu, 07 Apr 2016 19:34:41 +0200 Message-ID: <5660045.mydYX4O3xK@xps13> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: John Guzik , Yong Wang Return-path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 2492D2906 for ; Thu, 7 Apr 2016 19:34:43 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id u206so96733978wme.1 for ; Thu, 07 Apr 2016 10:34:43 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-04-07 17:11, John Guzik: > With the new jumbo frame patch a latent bug has appeared to have been uncovered: the VLAN offload is on the last rx descriptor, when rcd->eop is true, not the first rx descriptor, when rcd->sop is true and rcd->eop could be false. > Most likely the reason this has not been seen before is that for non-jumbo frames rcd->eop has always been true when rcd->sop is true as well. Thanks for reporting. Please Yong, could you confirm? John, 2 tags are needed to be applied: Fixes: commit-origin-of-the-bug Signed-off-by: Please check http://dpdk.org/dev#send for more details. Thanks