From mboxrd@z Thu Jan  1 00:00:00 1970
From: Panu Matilainen <pmatilai@redhat.com>
Subject: Re: [PATCH v2 10/12] mk: install examples
Date: Thu, 3 Dec 2015 15:35:47 +0200
Message-ID: <56604533.4050702@redhat.com>
References: <1449028676-19232-1-git-send-email-thomas.monjalon@6wind.com>
 <1449118929-19962-11-git-send-email-thomas.monjalon@6wind.com>
 <56604155.9080007@redhat.com> <5099957.difSTsvb7d@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id DA6EB2E81
 for <dev@dpdk.org>; Thu,  3 Dec 2015 14:35:49 +0100 (CET)
In-Reply-To: <5099957.difSTsvb7d@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/03/2015 03:32 PM, Thomas Monjalon wrote:
> 2015-12-03 15:19, Panu Matilainen:
>> On 12/03/2015 07:02 AM, Thomas Monjalon wrote:
>>> The examples are part of the installed documentation.
>>>
>>> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
>>> ---
>>>    mk/rte.sdkinstall.mk | 1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk
>>> index 902a933..13fa819 100644
>>> --- a/mk/rte.sdkinstall.mk
>>> +++ b/mk/rte.sdkinstall.mk
>>> @@ -154,3 +154,4 @@ ifneq ($(wildcard $O/doc/*/*/*pdf),)
>>>    	$(Q)$(call rte_mkdir,     $(DESTDIR)$(docdir)/guides)
>>>    	$(Q)cp -a $O/doc/*/*/*pdf $(DESTDIR)$(docdir)/guides
>>>    endif
>>> +	$(Q)cp -a $(RTE_SDK)/examples $(DESTDIR)$(datadir)
>>>
>>
>> If examples are considered documentation (and I agree on that), then
>> shouldn't they be installed in $(docdir) instead?
>
> I was hesitating. I think it's strange to install some code in
> /usr/share/doc/.
> It's not really important and may be changed easily at any time.
>

Installing source code anywhere at all seems a bit strange, being in doc 
seems like the least-worst alternative to me :) But like said, no big deal.

	- Panu -