From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [PATCH v2] mk: pass EXTRA_CFLAGS to AUTO_CPUFLAGS to
 enable local modifications
Date: Fri, 4 Dec 2015 11:15:40 +0100
Message-ID: <566167CC.3040303@6wind.com>
References: <20151124085001.58817bf0@miho> <56614AE8.2010200@netinsight.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
To: =?UTF-8?Q?Simon_K=c3=a5gstr=c3=b6m?= <simon.kagstrom@netinsight.net>,
 dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id B0340568A
 for <dev@dpdk.org>; Fri,  4 Dec 2015 11:15:46 +0100 (CET)
In-Reply-To: <56614AE8.2010200@netinsight.net>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Simon,

On 12/04/2015 09:12 AM, Simon K=E5gstr=F6m wrote:
> Hi Olivier!
>=20
> Does this commit look OK now with the changes you proposed?
>=20
> Thanks,
> // Simon
>=20
> On 2015-11-24 08:50, Simon Kagstrom wrote:
>> We have encountered a CPU where the AES-NI instruction set is disabled
>> due to export restrictions. Since the build machine and target machine
>> is different, using -native configs doesn't work, and on this CPU, the
>> application refuses to run due to the AES CPU flags being amiss.
>>
>> The patch passes EXTRA_CFLAGS to the figure-out-cpu-flags helper,
>> which allows us to add -mno-aes to the compile flags and resolve this
>> problem.
>>
>> Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
>> ---
>> ChangeLog:
>>
>> v2:
>> * Put EXTRA_CFLAGS after MACHINE_CFLAGS to enable overriding values
>>
>>  mk/rte.cpuflags.mk | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk
>> index bec7bdd..4b30c6b 100644
>> --- a/mk/rte.cpuflags.mk
>> +++ b/mk/rte.cpuflags.mk
>> @@ -33,7 +33,7 @@
>>  # used to set the RTE_CPUFLAG_* environment variables giving details
>>  # of what instruction sets the target cpu supports.
>> =20
>> -AUTO_CPUFLAGS :=3D $(shell $(CC) $(MACHINE_CFLAGS) -dM -E - < /dev/nu=
ll)
>> +AUTO_CPUFLAGS :=3D $(shell $(CC) $(MACHINE_CFLAGS) $(EXTRA_CFLAGS) -d=
M -E - < /dev/null)
>> =20
>>  # adding flags to CPUFLAGS
>> =20
>>


Acked-by: Olivier Matz <olivier.matz@6wind.com>