From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Simon_K=c3=a5gstr=c3=b6m?= Subject: Re: [PATCH] mk: fix warning spew when EXTRA_CFLAGS specifies warning flags Date: Mon, 7 Dec 2015 14:49:33 +0100 Message-ID: <56658E6D.6060901@netinsight.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Panu Matilainen , dev@dpdk.org Return-path: Received: from ernst.netinsight.se (ernst.netinsight.se [194.16.221.21]) by dpdk.org (Postfix) with SMTP id 5E04F95C7 for ; Mon, 7 Dec 2015 14:49:37 +0100 (CET) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2015-12-07 13:56, Panu Matilainen wrote: > Starting with commit 9aa2053c6e81493b23346ff4e387903560de5c81 > EXTRA_CFLAGS is sometimes being passed to the compiler without > WERROR_FLAGS which can cause spurious warnings by the dozen, > for example with when compiling with EXTRA_CFLAGS="-Wformat-security": > > cc1: warning: -Wformat-security ignored without -Wformat [-Wformat-security] > > Passing WERROR_FLAGS to AUTO_CPU helper makes the warning flag usage > consistent throughout the codebase, silencing the warnings. > [...] > diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk > index c6bb8de..28f203b 100644 > --- a/mk/rte.cpuflags.mk > +++ b/mk/rte.cpuflags.mk > @@ -33,7 +33,7 @@ > # used to set the RTE_CPUFLAG_* environment variables giving details > # of what instruction sets the target cpu supports. > > -AUTO_CPUFLAGS := $(shell $(CC) $(MACHINE_CFLAGS) $(EXTRA_CFLAGS) -dM -E - < /dev/null) > +AUTO_CPUFLAGS := $(shell $(CC) $(MACHINE_CFLAGS) $(WERROR_FLAGS) $(EXTRA_CFLAGS) -dM -E - < /dev/null) Acked-by: Simon Kagstrom