From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 2/2] eal: fix dynamic logs failing to print
Date: Tue, 21 Nov 2017 14:30:48 +0100
Message-ID: <5684106.7xpmVRmQS0@xps>
References: <20171116103144.4197-1-pbhagavatula@caviumnetworks.com>
 <1772478.GecVQuhyhE@xps> <20171121111416.yffsbci3cswwpzx5@Pavan-LT>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: ferruh.yigit@intel.com, olivier.matz@6wind.com, dev@dpdk.org
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 934D6235
 for <dev@dpdk.org>; Tue, 21 Nov 2017 14:30:49 +0100 (CET)
In-Reply-To: <20171121111416.yffsbci3cswwpzx5@Pavan-LT>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

21/11/2017 12:14, Pavan Nikhilesh Bhagavatula:
> On Tue, Nov 21, 2017 at 11:55:00AM +0100, Thomas Monjalon wrote:
> > 20/11/2017 19:40, Ferruh Yigit:
> > > And, since you are touching these files :),
> > > for better regex support, it may be good to have log types hierarchical, like
> > > "lib.mbuf", "lib.mempool", "lib.eal.malloc", as done in member library but with
> > > "lib" prefix instead of "librte", if this makes sense and you have time would
> > > you mind sending a patch for this as well?
> >
> > I am not sure about using eal in the library names.
> > I think lib.malloc is enough and it would allow to move malloc
> > (and other libraries) outside of EAL if needed.
> > We already moved PCI and VDEV outside of EAL. More could be moved.
> 
> Does this look good?
> 
> static const struct logtype logtype_strings[] = {
>     {RTE_LOGTYPE_EAL,        "lib.eal"},
>     {RTE_LOGTYPE_MALLOC,     "lib.malloc"},
>     {RTE_LOGTYPE_RING,       "lib.ring"},
>     {RTE_LOGTYPE_MEMPOOL,    "lib.mempool"},
>     {RTE_LOGTYPE_TIMER,      "lib.timer"},
>     {RTE_LOGTYPE_PMD,        "pmd"},
>     {RTE_LOGTYPE_HASH,       "lib.hash"},
>     {RTE_LOGTYPE_LPM,        "lib.lpm"},
>     {RTE_LOGTYPE_KNI,        "lib.kni"},
>     {RTE_LOGTYPE_ACL,        "lib.acl"},
>     {RTE_LOGTYPE_POWER,      "lib.power"},
>     {RTE_LOGTYPE_METER,      "lib.meter"},
>     {RTE_LOGTYPE_SCHED,      "lib.sched"},
>     {RTE_LOGTYPE_PORT,       "lib.port"},
>     {RTE_LOGTYPE_TABLE,      "lib.table"},
>     {RTE_LOGTYPE_PIPELINE,   "lib.pipeline"},
>     {RTE_LOGTYPE_MBUF,       "lib.mbuf"},
>     {RTE_LOGTYPE_CRYPTODEV,  "lib.cryptodev"},
>     {RTE_LOGTYPE_EFD,        "lib.efd"},
>     {RTE_LOGTYPE_EVENTDEV,   "lib.eventdev"},
>     {RTE_LOGTYPE_GSO,        "lib.gso"},
>     {RTE_LOGTYPE_USER1,      "user1"},
>     {RTE_LOGTYPE_USER2,      "user2"},
>     {RTE_LOGTYPE_USER3,      "user3"},
>     {RTE_LOGTYPE_USER4,      "user4"},
>     {RTE_LOGTYPE_USER5,      "user5"},
>     {RTE_LOGTYPE_USER6,      "user6"},
>     {RTE_LOGTYPE_USER7,      "user7"},
>     {RTE_LOGTYPE_USER8,      "user8"}
> };
> 
> I will be sending out the patch set soon.

These are only the legacy static log types.
Are you sure you want to change them?
They should be removed when using dynamic logging.