From mboxrd@z Thu Jan 1 00:00:00 1970 From: Declan Doherty Subject: Re: [PATCH 8/8] bond: do not activate slave twice Date: Tue, 5 Jan 2016 13:47:22 +0000 Message-ID: <568BC96A.5090004@intel.com> References: <1449249260-15165-1-git-send-email-stephen@networkplumber.org> <1449249260-15165-9-git-send-email-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Eric Kinzie To: Stephen Hemminger Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D63E39390 for ; Tue, 5 Jan 2016 14:48:19 +0100 (CET) In-Reply-To: <1449249260-15165-9-git-send-email-stephen@networkplumber.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 04/12/15 17:14, Stephen Hemminger wrote: > From: Eric Kinzie > > The current code for detecting link during slave addition can cause a > slave interface to be activated twice -- once during slave_configure() > and again at the end of __eth_bond_slave_add_lock_free(). This will > either cause the active slave count to be incorrect or will cause the > 802.3ad activation function to panic. Ensure that the interface is not > activated more than once. > > Signed-off-by: Eric Kinzie > Signed-off-by: Stephen Hemminger > --- ... > Acked-by: Declan Doherty