From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tan, Jianfeng" Subject: Re: [RFC 0/5] virtio support for container Date: Wed, 6 Jan 2016 13:47:28 +0800 Message-ID: <568CAA70.7070201@intel.com> References: <002a01d142e6$fbfeb4e0$f3fc1ea0$@samsung.com> <002401d143af$38a6fa60$a9f4ef20$@samsung.com> <002c01d143b7$568aace0$03a006a0$@samsung.com> <000301d143e1$6c5c0e90$45142bb0$@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit To: Pavel Fedin , dev@dpdk.org Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 3186F9432 for ; Wed, 6 Jan 2016 06:47:30 +0100 (CET) In-Reply-To: <000301d143e1$6c5c0e90$45142bb0$@samsung.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/31/2015 11:39 PM, Pavel Fedin wrote: > Hello! > > Last minute note. I have found the problem but have no time to research and fix it. > It happens because ovs first creates the device, starts it, then stops it, and reconfigures queues. The second queue allocation > happens from within netdev_set_multiq(). Then ovs restarts the device and proceeds to actually using it. > But, queues are not initialized properly in DPDK after the second allocation. Because of this thing: > > /* On restart after stop do not touch queues */ > if (hw->started) > return 0; Hi Fedin, As you see, I also think it is a bug. A device should be ok to start/stop/start... I already send a patch to fix this. http://dpdk.org/ml/archives/dev/2016-January/031010.html Thanks, Jianfeng > > It keeps us away from calling virtio_dev_rxtx_start(), which should in turn call virtio_dev_vring_start(), which calls > vring_init(). So, VIRTQUEUE_NUSED() dies badly because vq->vq_ring all contains NULLs. > See you all after 10th. And happy New Year again! > >