From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergio Gonzalez Monroy Subject: Re: [PATCH v4 1/1] change hugepage sorting to avoid overlapping memcpy Date: Thu, 7 Jan 2016 14:36:35 +0000 Message-ID: <568E77F3.8070408@intel.com> References: <568E3527.2080302@intel.com> <1452175142-17790-1-git-send-email-ralf.hoffmann@allegro-packets.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Ralf Hoffmann Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 05B9E95D5 for ; Thu, 7 Jan 2016 15:36:37 +0100 (CET) In-Reply-To: <1452175142-17790-1-git-send-email-ralf.hoffmann@allegro-packets.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ralf, It seems like the title update you did for v3 is missing in this patch. On 07/01/2016 13:59, Ralf Hoffmann wrote: > with only one hugepage or already sorted hugepage addresses, the sort > function called memcpy with same src and dst pointer. Debugging with > valgrind will issue a warning about overlapping area. This patch changes > the sort method to qsort to avoid this behavior. The separate sort > function is no longer necessary. > > Signed-off-by: Ralf Hoffmann > --- > Once you fix that you can add my Acked-by to your commit message. Acked-by: Sergio Gonzalez Monroy By the way, just a reminder to update the status of previous patches in patchwork as 'superseded'. Regards, Sergio