From mboxrd@z Thu Jan 1 00:00:00 1970 From: Panu Matilainen Subject: Re: [PATCH v3] Patch introducing API to read/write Intel Architecture Model Specific Registers (MSR)... Date: Thu, 21 Jan 2016 12:38:43 +0200 Message-ID: <56A0B533.5060201@redhat.com> References: <2601191342CEEE43887BDE71AB97725836AEC360@irsmsx105.ger.corp.intel.com> <1453364287-37283-1-git-send-email-wojciechx.andralojc@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" To: wojciechx.andralojc@intel.com Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 52F659197 for ; Thu, 21 Jan 2016 11:38:46 +0100 (CET) In-Reply-To: <1453364287-37283-1-git-send-email-wojciechx.andralojc@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01/21/2016 10:18 AM, Wojciech Andralojc wrote: > Patch reworked. > > Signed-off-by: Wojciech Andralojc > --- > lib/librte_eal/common/include/arch/x86/rte_msr.h | 88 +++++++++++++++++ > lib/librte_eal/linuxapp/eal/Makefile | 1 + > lib/librte_eal/linuxapp/eal/arch/x86/rte_msr.c | 116 +++++++++++++++++++++++ > 3 files changed, 205 insertions(+) > create mode 100644 lib/librte_eal/common/include/arch/x86/rte_msr.h > create mode 100644 lib/librte_eal/linuxapp/eal/arch/x86/rte_msr.c This creates a new arch-specific public API, with rte_msr.h installed as a public header and implementation in the library (as opposed to inline), and so the new functions would have to be added to rte_eal_version.map. However that is a bit of a problem since it only exists on IA architectures, so it'd mean dummy entries in the version map for all other architectures. All the other arch-specific APIs are inline code so this is the first of its kind. Jerin Jacob suggested [1] adding these as internal (inline) functions which to me looks like a more sensible approach, arch-specific APIs tend to be problematic. [1] http://dpdk.org/ml/archives/dev/2016-January/031095.html - Panu -