From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kamil Rytarowski Subject: Re: [PATCH v6 1/2] tools: Add support for handling built-in kernel modules Date: Thu, 28 Jan 2016 16:33:22 +0100 Message-ID: <56AA34C2.8050906@caviumnetworks.com> References: <1449667198-27218-1-git-send-email-Kamil.Rytarowski@caviumnetworks.com> <1872674.ygjbT6ghrC@xps13> <56A9F8D3.3010605@caviumnetworks.com> <5908931.I9BmIPpWAU@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Thomas Monjalon Return-path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0067.outbound.protection.outlook.com [207.46.100.67]) by dpdk.org (Postfix) with ESMTP id 919D4C48C for ; Thu, 28 Jan 2016 16:33:37 +0100 (CET) In-Reply-To: <5908931.I9BmIPpWAU@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" W dniu 28.01.2016 o 14:52, Thomas Monjalon pisze: > 2016-01-28 12:17, Kamil Rytarowski: > [...] >>>> + # special case for vfio_pci (module is named vfio-pci, >>>> + # but its .ko is named vfio_pci) >>> Isn't it common to have dash replaced by underscore for kernel modules? >>> >> I retained the logic for special case of vfio-pci. At the moment >> (according to my knowledge) there are no other DPDK modules with this >> name replacement. >> >> I checked few example Linux modules and if a module is named with dash, >> it's being replaced to underscore. The modprobe(8) tool can accept both >> names as interchangeable (with dash and underscore). >> >> Would you like to make it a general rule and replace all dashes with >> underscores? > I don't know. Do what you think is best. > Thanks I suggest to leave it as it is. There is no need to add a layer of abstraction for a single known exception. Also, this is out of scope of my patch. Thank you.