From mboxrd@z Thu Jan  1 00:00:00 1970
From: Fernando Seiti Furusato <ferseiti@linux.vnet.ibm.com>
Subject: Re: [PATCH] build: set CFLAGS for ppc64el build
Date: Fri, 12 Feb 2016 17:18:45 -0200
Message-ID: <56BE3015.7090804@linux.vnet.ibm.com>
References: <1455296713-7417-1-git-send-email-ferseiti@linux.vnet.ibm.com>
 <2231851.1TVA0CgCFh@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from e24smtp02.br.ibm.com (e24smtp02.br.ibm.com [32.104.18.86])
 by dpdk.org (Postfix) with ESMTP id 91EBB95D9
 for <dev@dpdk.org>; Fri, 12 Feb 2016 20:18:52 +0100 (CET)
Received: from localhost
 by e24smtp02.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
 Violators will be prosecuted
 for <dev@dpdk.org> from <ferseiti@linux.vnet.ibm.com>;
 Fri, 12 Feb 2016 17:18:49 -0200
Received: from d24relay02.br.ibm.com (d24relay02.br.ibm.com [9.13.184.26])
 by d24dlp02.br.ibm.com (Postfix) with ESMTP id 061F21DC006F
 for <dev@dpdk.org>; Fri, 12 Feb 2016 14:18:42 -0500 (EST)
Received: from d24av05.br.ibm.com (d24av05.br.ibm.com [9.18.232.44])
 by d24relay02.br.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id
 u1CJG76533685964 for <dev@dpdk.org>; Fri, 12 Feb 2016 17:16:07 -0200
Received: from d24av05.br.ibm.com (localhost [127.0.0.1])
 by d24av05.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
 u1CJIjlS021277 for <dev@dpdk.org>; Fri, 12 Feb 2016 14:18:45 -0500
In-Reply-To: <2231851.1TVA0CgCFh@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hello Thomas.
Thanks for your quick response.

On 02/12/2016 03:37 PM, Thomas Monjalon wrote:
> 2016-02-12 12:05, Fernando Seiti Furusato:
>> Add a proper ifeq statement to set the mcpu as needed for ppc64el, as
>> the only one originally set is not valid for ppc architectures.
>
> What is the benefit of using the default machine config, compared to
> the power8 one?
>
> Don't you think the default machine should be renamed core2?

I think it would be better indeed. Thanks for pointing that out.

>
> [...]
>> +ifeq (ppc64le,$(shell uname -m))
>> +        MACHINE_CFLAGS += -mcpu=power8
>
> Why this flag is not set in mk/machine/power8/rte.vars.mk ?
>

This and what observed above would make a better patch.
Let me try those.

Thanks!
-- 

Fernando Seiti Furusato
IBM Linux Technology Center