From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fernando Seiti Furusato Subject: Re: [PATCH] build: set CFLAGS for ppc64el build Date: Tue, 16 Feb 2016 17:07:43 -0200 Message-ID: <56C3737F.4090202@linux.vnet.ibm.com> References: <1455296713-7417-1-git-send-email-ferseiti@linux.vnet.ibm.com> <56BE3015.7090804@linux.vnet.ibm.com> <56C364A4.3010000@linux.vnet.ibm.com> <2641339.7y4mNALekD@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Thomas Monjalon Return-path: Received: from e24smtp03.br.ibm.com (e24smtp03.br.ibm.com [32.104.18.24]) by dpdk.org (Postfix) with ESMTP id BE606C134 for ; Tue, 16 Feb 2016 20:07:51 +0100 (CET) Received: from localhost by e24smtp03.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 16 Feb 2016 17:07:47 -0200 Received: from d24relay02.br.ibm.com (d24relay02.br.ibm.com [9.13.184.26]) by d24dlp02.br.ibm.com (Postfix) with ESMTP id F0C6D1DC0074 for ; Tue, 16 Feb 2016 14:07:39 -0500 (EST) Received: from d24av04.br.ibm.com (d24av04.br.ibm.com [9.8.31.97]) by d24relay02.br.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u1GJ541n60424372 for ; Tue, 16 Feb 2016 17:05:04 -0200 Received: from d24av04.br.ibm.com (localhost [127.0.0.1]) by d24av04.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u1GJ7iSM024868 for ; Tue, 16 Feb 2016 17:07:44 -0200 In-Reply-To: <2641339.7y4mNALekD@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 02/16/2016 04:09 PM, Thomas Monjalon wrote: > 2016-02-16 16:04, Fernando Seiti Furusato: >> Hi Thomas. >> >> On 02/12/2016 05:18 PM, Fernando Seiti Furusato wrote: >>> Hello Thomas. >>> Thanks for your quick response. >>> >>> On 02/12/2016 03:37 PM, Thomas Monjalon wrote: >>>> 2016-02-12 12:05, Fernando Seiti Furusato: >>>>> Add a proper ifeq statement to set the mcpu as needed for ppc64el, as >>>>> the only one originally set is not valid for ppc architectures. >>>> >>>> What is the benefit of using the default machine config, compared to >>>> the power8 one? >>>> >>>> Don't you think the default machine should be renamed core2? >>> >>> I think it would be better indeed. Thanks for pointing that out. >>> >>>> >>>> [...] >>>>> +ifeq (ppc64le,$(shell uname -m)) >>>>> + MACHINE_CFLAGS += -mcpu=power8 >>>> >>>> Why this flag is not set in mk/machine/power8/rte.vars.mk ? >>>> >>> >>> This and what observed above would make a better patch. >>> Let me try those. >> >> I will be just changing the flag within mk/machine/power8/rte.vars.mk so >> it will be used on ppc64le. > > Does it mean that only little endian is supported on POWER8? Not exactly. It is just that I work mainly on LE. It would probably work on big endian too. > >> I thought since I am not sure how it will affect others, I will not mess >> with the default file. > > Yes let's keep it for another patch if someone is concerned. > >> I had to copy config/defconfig_ppc_64-power8-linuxapp-gcc to >> config/defconfig_ppc64le-native-linuxapp-gcc, because the build searches >> for it on ppc64le. Should I include that in the patch? >> Do you think there is a better approach? > > Not sure to understand. > I think there is something wrong in the commands you use to compile. > Are you using "make config T=ppc_64-power8-linuxapp-gcc" ? > Nah, never mind about this one. You are right, I messed it up. I copied the line from what was generated by debian/rules on the ubuntu package. Thanks. -- Fernando Seiti Furusato IBM Linux Technology Center