From mboxrd@z Thu Jan 1 00:00:00 1970 From: Panu Matilainen Subject: Re: [PATCH] vhost: add missing build dependency on librte_net Date: Thu, 18 Feb 2016 16:07:52 +0200 Message-ID: <56C5D038.2070700@redhat.com> References: <20160218132549.GN21426@yliu-dev.sh.intel.com> <56C5C98E.7010205@redhat.com> <20160218135603.GO21426@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Yuanhan Liu Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 09F8BC312 for ; Thu, 18 Feb 2016 15:07:55 +0100 (CET) In-Reply-To: <20160218135603.GO21426@yliu-dev.sh.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 02/18/2016 03:56 PM, Yuanhan Liu wrote: > On Thu, Feb 18, 2016 at 03:39:26PM +0200, Panu Matilainen wrote: >> On 02/18/2016 03:25 PM, Yuanhan Liu wrote: >>> On Thu, Feb 18, 2016 at 11:47:43AM +0200, Panu Matilainen wrote: >>>> Commit d0cf91303d73 added dependency on librte_net headers to vhost >>>> but did not add this to the Makefile, which makes builds >>>> non-deterministic. Curiously it is non-parallel build that is >>>> consistently broken by this missing dependency, usually it's the other >>>> way around, but trying to build without -j(n) fails with: >>> >>> Yeah, I have confirmed it; I was wondering why I didn't meet such build >>> error. >>> >>>> >>>> dpdk/lib/librte_vhost/vhost_rxtx.c:41:20: >>>> fatal error: rte_ip.h: No such file or directory >>>> >>>> Fixes: d0cf91303d73 ("vhost: add Tx offload capabilities") >>>> Signed-off-by: Panu Matilainen >>> >>> Acked-by: Yuanhan Liu >>> >>> Thanks. >>> >>> BTW, please cc me for virtio/vhost patches next time, otherwise, it's >>> easily got overlooked: too many emails. >> >> Hmm, I thought I did. Looking more carefully now, I mixed up the patch >> author (who was CC'd) with you: > > I didn't see the author was cc'ed from my email client: > > Date: Thu, 18 Feb 2016 11:47:43 +0200 > From: Panu Matilainen > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net Hmm, indeed. But this is what git told me (happened to have the whole thing in scrollback buffer): [pmatilai@sopuli dpdk]$ git send-email --cc="jijiang.liu@intel.com" --cc="huawei.xie@intel.com" -1 /tmp/ZAW8ErlHWe/0001-vhost-add-missing-build-dependency-on-librte_net.patch From: Panu Matilainen To: dev@dpdk.org Cc: jijiang.liu@intel.com, huawei.xie@intel.com Subject: [PATCH] vhost: add missing build dependency on librte_net Date: Thu, 18 Feb 2016 11:47:43 +0200 Message-Id: X-Mailer: git-send-email 2.5.0 Send this email? ([y]es|[n]o|[q]uit|[a]ll): a OK. Log says: Server: smtp.corp.redhat.com MAIL FROM: RCPT TO: RCPT TO: RCPT TO: From: Panu Matilainen To: dev@dpdk.org Cc: jijiang.liu@intel.com, huawei.xie@intel.com Subject: [PATCH] vhost: add missing build dependency on librte_net Date: Thu, 18 Feb 2016 11:47:43 +0200 Message-Id: X-Mailer: git-send-email 2.5.0 So where do the CC's vanish? >> >> commit d0cf91303d731997945420832ee245b21f292e19 >> Author: Jijiang Liu >> >> I hate it when people call me Paul (commonly happens) just because it > > Hmm... I didn't call you that, right? No, not you :) >> vaguely resembles my name, > > Indeed :) > >> so I really should do better than this. >> Apologies, I'll pay closer attention in the future. > > Never mind, it's not a big deal. Emails with me CC'ed are highlighted > in my mutt email client, therefore, it's unlikely I will miss them. > > --yliu > Sure. We all get too much email :) - Panu -