From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH 2/6] mempool: add stack (lifo) based external mempool handler Date: Fri, 19 Feb 2016 14:31:05 +0100 Message-ID: <56C71919.50506@6wind.com> References: <1453829155-1366-1-git-send-email-david.hunt@intel.com> <1455634095-4183-1-git-send-email-david.hunt@intel.com> <1455634095-4183-3-git-send-email-david.hunt@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: David Hunt , dev@dpdk.org Return-path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 0A096C54E for ; Fri, 19 Feb 2016 14:31:12 +0100 (CET) In-Reply-To: <1455634095-4183-3-git-send-email-david.hunt@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi David, On 02/16/2016 03:48 PM, David Hunt wrote: > adds a simple stack based mempool handler > > Signed-off-by: David Hunt > --- > lib/librte_mempool/Makefile | 2 +- > lib/librte_mempool/rte_mempool.c | 4 +- > lib/librte_mempool/rte_mempool.h | 1 + > lib/librte_mempool/rte_mempool_stack.c | 164 +++++++++++++++++++++++++++++++++ > 4 files changed, 169 insertions(+), 2 deletions(-) > create mode 100644 lib/librte_mempool/rte_mempool_stack.c > I don't get what is the purpose of this handler. Is it an example or is it something that could be useful for dpdk applications? If it's an example, we should find a way to put the code outside the librte_mempool library, maybe in the test program. I see there is also a "custom handler". Do we really need to have both? Regards, Olivier