From mboxrd@z Thu Jan  1 00:00:00 1970
From: Panu Matilainen <pmatilai@redhat.com>
Subject: Re: [PATCH] config: remove duplicate configuration
 information
Date: Mon, 22 Feb 2016 18:44:08 +0200
Message-ID: <56CB3AD8.1040807@redhat.com>
References: <1456149217-24833-1-git-send-email-keith.wiles@intel.com>
 <348A99DA5F5B7549AA880327E580B43588F70F25@IRSMSX101.ger.corp.intel.com>
 <3158B4E6-B902-47B7-A7DA-68AEC8C53A84@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
To: "Wiles, Keith" <keith.wiles@intel.com>,
 "Trahe, Fiona" <fiona.trahe@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 811592BE0
 for <dev@dpdk.org>; Mon, 22 Feb 2016 17:44:11 +0100 (CET)
In-Reply-To: <3158B4E6-B902-47B7-A7DA-68AEC8C53A84@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 02/22/2016 06:02 PM, Wiles, Keith wrote:
>> Hi Keith,
>>
>> What makes a param common?
>>
>> e.g.  cryptodev QAT PMD is supported in linux, but currently not supported in bsd.
>> So typically I disable it in the bsd file and enable it in the linux file.
>>
>> Couldn't the same apply to any other parameter, i.e. there may be users who want to have differences in config for different OSs?
>>
>> So why not just leave as is and give users the option to choose?
>
> The problem is the major configs are all common, in this design we have the common_base all configs are placed then as you stated they are disable in the common_OS files. Plus some are enabled/disabled in the deconfig_XXX files as well.
>
> The goal is to move all of the configs into one file then we do not have to keep updating all of the common_OS files, but only enable/disable that option.
>
> I have common_osxapp that I want to add later to build and run DPDK on OS X, which is another place to have these same configs. Later we may add another OS too, which means more copies :-)
>

My +1 for eliminating config redundancy. In addition to improving 
overall sanity, having the common options in a common file makes the few 
actually OS-dependent items stand out, which is only a good thing.

	- Panu -