From mboxrd@z Thu Jan 1 00:00:00 1970 From: Remy Horton Subject: Re: [PATCH v1 0/3] Add missing ethdev driver support Date: Tue, 23 Feb 2016 12:19:13 +0000 Message-ID: <56CC4E41.4040109@intel.com> References: <1453970895-2639-1-git-send-email-remy.horton@intel.com> <20160216105452.0b1da99f@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Stephen Hemminger Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 58E80201 for ; Tue, 23 Feb 2016 13:19:16 +0100 (CET) In-Reply-To: <20160216105452.0b1da99f@xeon-e3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 16/02/2016 18:54, Stephen Hemminger wrote: > On Thu, 28 Jan 2016 08:48:12 +0000 > Remy Horton wrote: > >> Several rte_eth_dev_* functions are currently only supported >> by the ixgbe NIC driver. This patchset adds driver support >> for some of these functions to the i40e, virtio, and vmxnet3 >> drivers. > > It is good to make drivers more complete and compatible, but unless > the virtual driver has some useful data I can't see the point of providing > these functions in this case. The base infrastructure (rte_ethdev) should > deal with by returning not supported error (or all zeros); rather than > creating more code in other drivers for no real gain. Come to the same conclusion regarding the Rx/Tx queue info functions, as working out how to derive the figures I could return was also baking in some implicit assumptions. Plan to exclude those ones from the v2. ..Remy