From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 2/4] kcp: add kernel control path kernel
 module
Date: Tue, 1 Mar 2016 15:53:23 +0000
Message-ID: <56D5BAF3.9090508@intel.com>
References: <1455284735-9606-1-git-send-email-ferruh.yigit@intel.com>
 <1456495841-15749-1-git-send-email-ferruh.yigit@intel.com>
 <1456495841-15749-3-git-send-email-ferruh.yigit@intel.com>
 <20160229170241.46e32284@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id B94E29A98
 for <dev@dpdk.org>; Tue,  1 Mar 2016 16:53:25 +0100 (CET)
In-Reply-To: <20160229170241.46e32284@xeon-e3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/1/2016 1:02 AM, Stephen Hemminger wrote:
> On Fri, 26 Feb 2016 14:10:39 +0000
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
>> +#define KCP_ERR(args...) printk(KERN_ERR "KCP: " args)
>> +#define KCP_INFO(args...) printk(KERN_INFO "KCP: " args)
>> +
>> +#ifdef RTE_KCP_KO_DEBUG
>> +#define KCP_DBG(args...) printk(KERN_DEBUG "KCP: " args)
>> +#else
>> +#define KCP_DBG(args...)
>> +#endif
> 
> These macros will not make netdev developers happy.
> 
> Use standard printk macros, and if you want prefix, use pr_fmt
> 
> 
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> 
Hi Stephen,

I removed the macros and send a new version of patch set.

v4:
http://dpdk.org/dev/patchwork/patch/10950/

Thanks,
ferruh