From mboxrd@z Thu Jan 1 00:00:00 1970 From: Panu Matilainen Subject: Re: [PATCH v6 1/4] lib/ether: optimize the'rte_eth_tunnel_filter_conf' structure Date: Wed, 2 Mar 2016 09:12:09 +0200 Message-ID: <56D69249.6040609@redhat.com> References: <1455867097-19173-1-git-send-email-xutao.sun@intel.com> <1456804032-1682-1-git-send-email-xutao.sun@intel.com> <1456804032-1682-2-git-send-email-xutao.sun@intel.com> <56D5588D.80205@redhat.com> <9AC567D38896294095E6F3228F697FC803533BC9@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: "Sun, Xutao" , "dev@dpdk.org" Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 9E97B9AD3 for ; Wed, 2 Mar 2016 08:12:10 +0100 (CET) In-Reply-To: <9AC567D38896294095E6F3228F697FC803533BC9@shsmsx102.ccr.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 03/02/2016 05:10 AM, Sun, Xutao wrote: > Hi, Panu > >> -----Original Message----- >> From: Panu Matilainen [mailto:pmatilai@redhat.com] >> Sent: Tuesday, March 01, 2016 4:54 PM >> To: Sun, Xutao ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v6 1/4] lib/ether: optimize >> the'rte_eth_tunnel_filter_conf' structure >> >> On 03/01/2016 05:47 AM, Xutao Sun wrote: >>> Change the fields of outer_mac and inner_mac from pointer to struct in >>> order to keep the code's readability. >>> >>> Signed-off-by: Xutao Sun >>> Signed-off-by: Jijiang Liu >>> --- >>> app/test-pmd/cmdline.c | 6 ++++-- >>> doc/guides/rel_notes/deprecation.rst | 5 ----- >>> doc/guides/rel_notes/release_16_04.rst | 2 ++ >>> drivers/net/i40e/i40e_ethdev.c | 12 ++++++------ >>> lib/librte_ether/rte_eth_ctrl.h | 4 ++-- >>> 5 files changed, 14 insertions(+), 15 deletions(-) >>> >> >> Since this is the commit actually changing the ABI, its best to actually bump >> LIBABIVER right here as well lest it go forgotten, and also update the list of >> shared library versions in release notes. >> See commit d8c4ae275582784ec0ff3b2c54a4c861b55bc056 for an example. >> >> Oh and sorry for not noticing this earlier. >> >> - Panu - > > I didn't use the Macro "RTE_NEXT_ABI", so I think I don't need to update the shared library verisons. > And I also updated the doc about ABI change in the deprecation.rst and release notes. Shared library version MUST change when there's an incompatible change to prevent programs/libraries linked against the older version to be used with the incompatible version, that is the sole reason for versioning the libraries in the first place. Whether RTE_NEXT_ABI is used or not is not relevant. In fact RTE_NEXT_ABI creates a shared library version of its own, sort of parallel to the current one. The basic idea remains the same though: shared library version has to change when an incompatible change goes in. - Panu - - Panu - - Panu - - Panu -