From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v4 2/4] kcp: add kernel control path kernel
 module
Date: Wed, 2 Mar 2016 11:06:29 +0000
Message-ID: <56D6C935.3090306@intel.com>
References: <1456495841-15749-1-git-send-email-ferruh.yigit@intel.com>
 <1456846920-28770-1-git-send-email-ferruh.yigit@intel.com>
 <1456846920-28770-3-git-send-email-ferruh.yigit@intel.com>
 <20160301151058.6e1731d1@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 8D35D2617
 for <dev@dpdk.org>; Wed,  2 Mar 2016 12:06:31 +0100 (CET)
In-Reply-To: <20160301151058.6e1731d1@xeon-e3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/1/2016 11:10 PM, Stephen Hemminger wrote:
> On Tue,  1 Mar 2016 15:41:58 +0000
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
>> +struct kcp_ethtool_msg {
>> +	int cmd_id;
>> +	int port_id;
>> +	unsigned int flag;
>> +	char input_buffer[KCP_ETHTOOL_MSG_LEN];
>> +	char output_buffer[KCP_ETHTOOL_MSG_LEN];
>> +	int input_buffer_len;
>> +	int output_buffer_len;
>> +	int err;
>> +};
>> +
> 
> In general try and use unsigned where ever it is possible.
> Having int and char types was the C style back in Unix, but now
> most code use size_t, uint32_t and uint8_t.
> 
Thanks for the comments, this and previous ones, I will update accordingly.

> 
> You seem to be trying to force ethtool into netlink.
> There are some others doing that already, so following their work
> would be good.
> 
Sure I would like to check them, where can I find them? inside the kernel?

Thanks,
ferruh