From mboxrd@z Thu Jan  1 00:00:00 1970
From: Panu Matilainen <pmatilai@redhat.com>
Subject: Re: [PATCH] config: remove duplicate configuration
 information
Date: Fri, 4 Mar 2016 11:39:00 +0200
Message-ID: <56D957B4.4090104@redhat.com>
References: <1456149217-24833-1-git-send-email-keith.wiles@intel.com>
 <121442835.2vdhmXQbJs@xps13>
 <BC0FEEC7D7650749874CEC11314A88F7454364C5@IRSMSX104.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Traynor, Kevin" <kevin.traynor@intel.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>,
 "Wiles, Keith" <keith.wiles@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 2F71F1396
 for <dev@dpdk.org>; Fri,  4 Mar 2016 10:39:03 +0100 (CET)
In-Reply-To: <BC0FEEC7D7650749874CEC11314A88F7454364C5@IRSMSX104.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 03/04/2016 11:28 AM, Traynor, Kevin wrote:
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
>> Sent: Thursday, March 3, 2016 6:38 PM
>> To: Wiles, Keith <keith.wiles@intel.com>
>> Cc: dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] config: remove duplicate configuration
>> information
>>
>> 2016-02-22 07:53, Keith Wiles:
>>> --- /dev/null
>>> +++ b/config/common_base
>>> +CONFIG_RTE_EAL_IGB_UIO=y
>>> +CONFIG_RTE_EAL_VFIO=y
>>
>> These options should be disabled in the base file
>> and enabled in Linux.
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

>>
>>> +CONFIG_RTE_LIBRTE_PMD_AF_PACKET=y
>>
>> Idem, it should be disabled.
>>
>>> +CONFIG_RTE_LIBRTE_POWER=y
>>
>> Idem?
>>
>>> +CONFIG_RTE_LIBRTE_KNI=y
>>
>> Should be disabled.
>>
>>> +CONFIG_RTE_LIBRTE_VHOST=y
>>
>> Should be disabled.
>
> Any reason this should be disabled? It was changed to =Y in DPDK 2.1.

That's what I first thought too, but I think Thomas meant "disable in 
common_base, enable in Linux config" for all these.

	- Panu -