From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] bonding: fix crash when no slave devices
Date: Fri, 4 Mar 2016 17:13:31 +0000
Message-ID: <56D9C23B.8000508@intel.com>
References: <1456229580-25009-1-git-send-email-bernard.iremonger@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
To: Bernard Iremonger <bernard.iremonger@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 7B9402B9E
 for <dev@dpdk.org>; Fri,  4 Mar 2016 18:13:35 +0100 (CET)
In-Reply-To: <1456229580-25009-1-git-send-email-bernard.iremonger@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2/23/2016 12:13 PM, Bernard Iremonger wrote:
> If a bonded device is created when there are no slave devices
> there is loop in bond_ethdev_promiscous_enable() which results
> in a segmentation fault.
> I have applied a similar fix to bond_ethdev_promiscous_disable()
> where a similar loop could occur.
>=20
> Fixes: 2efb58cbab6e ("bond: new link bonding library")
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
>  drivers/net/bonding/rte_eth_bond_pmd.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bondi=
ng/rte_eth_bond_pmd.c
> index b63c886..78972fc 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -1870,7 +1870,8 @@ bond_ethdev_promiscuous_enable(struct rte_eth_dev=
 *eth_dev)
>  	case BONDING_MODE_TLB:
>  	case BONDING_MODE_ALB:
>  	default:
> -		rte_eth_promiscuous_enable(internals->current_primary_port);
> +		if (internals->slave_count > 0)
> +			rte_eth_promiscuous_enable(internals->current_primary_port);
>  	}
>  }
> =20
> @@ -1898,7 +1899,8 @@ bond_ethdev_promiscuous_disable(struct rte_eth_de=
v *dev)
>  	case BONDING_MODE_TLB:
>  	case BONDING_MODE_ALB:
>  	default:
> -		rte_eth_promiscuous_disable(internals->current_primary_port);
> +		if (internals->slave_count > 0)
> +			rte_eth_promiscuous_disable(internals->current_primary_port);
>  	}
>  }
> =20
>=20
Hi Bernard,

The reason of this crash is when there is no slave, the value of
current_primary_port is 0, which is valid port_id, is this correct?

Does it make sense, instead of slave_count check, to make default
current_primary_port value a non valid port_id, like -1, so
is_valid_port() check catches it to prevents crash? For this and any
other cases.

Thanks,
ferruh