From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 3/3] scripts: ignore self-generated directories in validate-abi startup check Date: Thu, 10 Mar 2016 12:22:25 +0000 Message-ID: <56E16701.5060502@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable To: Panu Matilainen , dev@dpdk.org Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id A4BBA2BBC for ; Thu, 10 Mar 2016 13:22:48 +0100 (CET) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/10/2016 10:53 AM, Panu Matilainen wrote: > When doing multiple runs of validate-abi.sh, the git status check > will more often than not unnecessarily fail with "Working directory not > clean" error because of the compat_result and compile target directorie= s > from the previous run. Filter out the self-generated directories > when checking. >=20 > Signed-off-by: Panu Matilainen > --- > scripts/validate-abi.sh | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/scripts/validate-abi.sh b/scripts/validate-abi.sh > index ea60639..a21f883 100755 > --- a/scripts/validate-abi.sh > +++ b/scripts/validate-abi.sh > @@ -163,8 +163,7 @@ log "INFO" "against DPDK DSOs built from version $T= AG2." > log "INFO" "" > =20 > # Check to make sure we have a clean tree > -git status | grep -q clean > -if [ $? -ne 0 ] > +if [ $(git status --porcelain | grep -vE "($TARGET|compat_reports)" | = wc -l) -ne 0 ] > then > log "WARN" "Working directory not clean, aborting" > cleanup_and_exit 1 >=20 Hi Panu, This check catches untracked files too, does it makes sense to limit error only to modified files (local or staged)? This also prevents specific "compat_reports" folder check. And of course mentioned change requires "git clean -fd" removed, or replaced with "make clean" Thanks, ferruh