From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Subject: Re: Fw: dpdk-armv7 - Build # 342 - Failure!
Date: Fri, 11 Mar 2016 14:53:23 +0000
Message-ID: <56E2DBE3.4030309@intel.com>
References: <20160311123910.779f9c2e@jvn> <56E2B065.3090108@intel.com>
 <2098276.9k93xeoVuW@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Jan Viktorin <viktorin@rehivetech.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 8D9222931
 for <dev@dpdk.org>; Fri, 11 Mar 2016 15:53:27 +0100 (CET)
In-Reply-To: <2098276.9k93xeoVuW@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/03/2016 13:33, Thomas Monjalon wrote:
> 2016-03-11 11:47, Sergio Gonzalez Monroy:
>> On 11/03/2016 11:39, Jan Viktorin wrote:
>>> Hello Sergio,
>>>
>>> I've detected a build regression for the ARMv7. It seems to me the
>>> source of the problem is the following commit:
>>>
>>>    http://dpdk.org/browse/dpdk/commit/?id=d299106e8e31a622b3a1c1653f7795fa8a55860e
>>>
>>> The ipsec-secgw should be compiled only when LPM is enabled. See, eg.
>>> how the l3fwd-power example is done in examples/Makefile.
>> Right!
>>
>> Actually the app has dependencies on a few libraries, so I'll fix that.
> Please take the opportunity to move the crypto examples in the
> alphabetical order in this Makefile. Thanks
>
>

So the fix is easy enough but I'm really not a fan of cluttering the 
examples/Makefile ifeq checks
which would only avoid building ipsec-secgw if doing:
$ make examples

but would still fail to build if doing something like:
$ make -C examples/ipsec-secgw

I reckon that there are other CONFIG_XXX combinations that would results 
in failed builds.

So before sending the patch, this would be what we are getting:

examples/Makefile:
+ifeq ($(CONFIG_RTE_LIBRTE_ACL),y)
+ifeq ($(CONFIG_RTE_LIBRTE_HASH),y)
+ifeq ($(CONFIG_RTE_LIBRTE_LPM),y)
DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += ipsec-secgw
+endif
+endif
+endif

Another way to achive this and also avoid building the app with 'make -C 
...' is something like this:

examples/ipsec-secgw/Makefile:
+all:
+%:

+ifeq ($(CONFIG_RTE_LIBRTE_ACL),y)
+ifeq ($(CONFIG_RTE_LIBRTE_HASH),y)
+ifeq ($(CONFIG_RTE_LIBRTE_LPM),y)
+ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)
include $(RTE_SDK)/mk/rte.extapp.mk
+endif
+endif
+endif
+endif

Anyway, none of those are the right fix, which I think should be 
something along the lines of Kconfig.

Any preference?

Sergio