From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Subject: Re: Fw: dpdk-armv7 - Build # 342 - Failure!
Date: Fri, 11 Mar 2016 15:11:57 +0000
Message-ID: <56E2E03D.2010901@intel.com>
References: <20160311123910.779f9c2e@jvn> <2098276.9k93xeoVuW@xps13>
 <56E2DBE3.4030309@intel.com> <2101263.CINWvX51Cb@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Jan Viktorin <viktorin@rehivetech.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 1968E2C45
 for <dev@dpdk.org>; Fri, 11 Mar 2016 16:11:59 +0100 (CET)
In-Reply-To: <2101263.CINWvX51Cb@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/03/2016 15:04, Thomas Monjalon wrote:
> 2016-03-11 14:53, Sergio Gonzalez Monroy:
>> On 11/03/2016 13:33, Thomas Monjalon wrote:
>>> 2016-03-11 11:47, Sergio Gonzalez Monroy:
>>>> On 11/03/2016 11:39, Jan Viktorin wrote:
>>>>> Hello Sergio,
>>>>>
>>>>> I've detected a build regression for the ARMv7. It seems to me the
>>>>> source of the problem is the following commit:
>>>>>
>>>>>     http://dpdk.org/browse/dpdk/commit/?id=d299106e8e31a622b3a1c1653f7795fa8a55860e
>>>>>
>>>>> The ipsec-secgw should be compiled only when LPM is enabled. See, eg.
>>>>> how the l3fwd-power example is done in examples/Makefile.
>>>> Right!
>>>>
>>>> Actually the app has dependencies on a few libraries, so I'll fix that.
>>> Please take the opportunity to move the crypto examples in the
>>> alphabetical order in this Makefile. Thanks
>>>
>>>
>> So the fix is easy enough but I'm really not a fan of cluttering the
>> examples/Makefile ifeq checks
>> which would only avoid building ipsec-secgw if doing:
>> $ make examples
>>
>> but would still fail to build if doing something like:
>> $ make -C examples/ipsec-secgw
> If you explicitly want to build this example, it is normal to fail.

Fair enough.
>> examples/Makefile:
>> +ifeq ($(CONFIG_RTE_LIBRTE_ACL),y)
>> +ifeq ($(CONFIG_RTE_LIBRTE_HASH),y)
>> +ifeq ($(CONFIG_RTE_LIBRTE_LPM),y)
>> DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += ipsec-secgw
>> +endif
>> +endif
>> +endif
> You can do it in one line:
> ifeq ($(CONFIG_RTE_LIBRTE_ACL)$(CONFIG_RTE_LIBRTE_HASH)$(CONFIG_RTE_LIBRTE_LPM),yyy)

The line above goes to 85 chars, are you ok with that? or do I split it 
in two lines?

Sergio