From mboxrd@z Thu Jan  1 00:00:00 1970
From: Markos Chandras <mchandras@suse.de>
Subject: Re: [PATCH] mk: toolchain: gcc: query the compiler
 macros to obtain the gcc version
Date: Wed, 23 Mar 2016 09:56:02 +0000
Message-ID: <56F26832.8020805@suse.de>
References: <1458666816-29778-1-git-send-email-mchandras@suse.de>
 <2653966.ML0Fr8PsdQ@xps13> <56F1CC20.50707@suse.de>
 <10969139.eXE434OmqC@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by dpdk.org (Postfix) with ESMTP id 4968DFFA
 for <dev@dpdk.org>; Wed, 23 Mar 2016 10:56:04 +0100 (CET)
In-Reply-To: <10969139.eXE434OmqC@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 03/23/2016 09:49 AM, Thomas Monjalon wrote:
> 2016-03-22 22:50, Markos Chandras:
>> On 22/03/16 22:34, Thomas Monjalon wrote:
>>> 2016-03-22 17:13, Markos Chandras:
>>>> This is similar to what's being used in the Linux kernel. Querying the
>>>> GCC macros directly gives more accurate results compared to -dumpversion
>>>> which could vary across distributions.
>>>>
>>>> Signed-off-by: Markos Chandras <mchandras@suse.de>
>>>> ---
>>>> In openSUSE Tumbleweed (and in any other SUSE distribution which
>>>> uses (or will use) gcc >= 5), gcc -dumpversion returns '5'. This is on
>>>> purpose as discussed in https://bugzilla.opensuse.org/show_bug.cgi?id=941428
>>>
>>> Good to know. It could be in the commit log.
>>
>> I can add this information to the commit message and send a v2 if needed.
> 
> I will apply with this info.

Thank you Thomas.

-- 
markos