From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nelson Escobar <neescoba@cisco.com>
Subject: Re: [PATCH] bonding: fix bond link detect in
 non-interrupt mode
Date: Thu, 31 Mar 2016 10:33:21 -0700
Message-ID: <56FD5F61.9010002@cisco.com>
References: <1458953090-12764-1-git-send-email-johndale@cisco.com>
 <5397245.3TK0dfaEoQ@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
 "John Daley (johndale)" <johndale@cisco.com>
Return-path: <dev-bounces@dpdk.org>
Received: from rcdn-iport-5.cisco.com (rcdn-iport-5.cisco.com [173.37.86.76])
 by dpdk.org (Postfix) with ESMTP id 9AD8B95CA
 for <dev@dpdk.org>; Thu, 31 Mar 2016 19:33:22 +0200 (CEST)
In-Reply-To: <5397245.3TK0dfaEoQ@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Thomas,

Sorry, I should have included the following fixes line:

Fixes: a45b288ef21a("bond: support link status polling")

Please add it to the commit message when applying if there are no other
problems with the patch.

Nelson.
On 3/31/2016 6:40 AM, Thomas Monjalon wrote:
> 2016-03-25 17:44, John Daley:
>> From: Nelson Escobar <neescoba@cisco.com>
>>
>> Stopping then re-starting a bond interface containing slaves that
>> used polling for link detection caused the bond to think all slave
>> links were down and inactive.
>>
>> Move the start of the polling for link from slave_add() to
>> bond_ethdev_start() and in bond_ethdev_stop() make sure we clear
>> the last_link_status of the slaves.
>>
>> Signed-off-by: Nelson Escobar <neescoba@cisco.com>
>> Signed-off-by: John Daley <johndale@cisco.com>
> 
> A "Fixes:" line would be appreciated to know the origin of the bug.
> Thanks
>