From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] drivers/net: set close behaviour flag at
	probing
Date: Mon, 12 Nov 2018 15:28:31 +0000
Message-ID: <56eaee8e-702d-0d9d-7cb8-b1a7533d501c@intel.com>
References: <20181111224611.19234-1-thomas@monjalon.net>
 <1542015769.11515.0.camel@debian.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: ophirmu@mellanox.com, mk@semihalf.com
To: Luca Boccassi <bluca@debian.org>, Thomas Monjalon <thomas@monjalon.net>,
 dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 482C691
 for <dev@dpdk.org>; Mon, 12 Nov 2018 16:28:34 +0100 (CET)
In-Reply-To: <1542015769.11515.0.camel@debian.org>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/12/2018 9:42 AM, Luca Boccassi wrote:
> On Sun, 2018-11-11 at 23:46 +0100, Thomas Monjalon wrote:
>> The ethdev flag RTE_ETH_DEV_CLOSE_REMOVE is set for drivers
>> having migrated to the new behaviour of rte_eth_dev_close().
>>
>> As any other flag, it can be useful to know about its value
>> as soon as the port is probed.
>> Unfortunately, it was set inside the close operation,
>> just before being erased by memset() in rte_eth_dev_release_port().
>> The flag assignment is moved to the probing stage, so it can
>> be checked by the application in order to anticipate the behaviour.
>>
>> Fixes: 42603bbdb58e ("net/mlx5: release port on close")
>> Cc: ophirmu@mellanox.com
>> Fixes: 6c99085d972b ("net/vmxnet3: fix hot-unplug")
>> Cc: bluca@debian.org
>> Fixes: 4d7877fde2ef ("net/ena: remove resources when port is being
>> closed")
>> Cc: mk@semihalf.com
>>
>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>> ---
>>  drivers/net/ena/ena_ethdev.c         | 11 ++++++-----
>>  drivers/net/mlx5/mlx5.c              |  7 ++-----
>>  drivers/net/vmxnet3/vmxnet3_ethdev.c |  9 +++------
>>  3 files changed, 11 insertions(+), 16 deletions(-)
> 
> Acked-by: Luca Boccassi <bluca@debian.org>
> 
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.