From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Subject: Re: [PATCH v2] virtio: use zeroed memory for simple TX
 header
Date: Tue, 5 Apr 2016 13:34:18 +0800
Message-ID: <57034E5A.8040402@intel.com>
References: <1459822261-95284-1-git-send-email-rlane@bigswitch.com>
 <57032EE5.4050408@intel.com> <20160405042654.GN3080@yliu-dev.sh.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Rich Lane <rich.lane@bigswitch.com>, dev@dpdk.org,
 Huawei Xie <huawei.xie@intel.com>,
 Stephen Hemminger <stephen@networkplumber.org>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 7C05911C5
 for <dev@dpdk.org>; Tue,  5 Apr 2016 07:34:36 +0200 (CEST)
In-Reply-To: <20160405042654.GN3080@yliu-dev.sh.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

On 4/5/2016 12:26 PM, Yuanhan Liu wrote:
> On Tue, Apr 05, 2016 at 11:20:05AM +0800, Tan, Jianfeng wrote:
>> Hi,
>>
>> On 4/5/2016 10:11 AM, Rich Lane wrote:
>>> For simple TX the virtio-net header must be zeroed, but it was using memory
>>> that had been initialized with indirect descriptor tables. This resulted in
>>> "unsupported gso type" errors from librte_vhost.
>>>
>>> We can use the same memory for every descriptor to save cachelines in the
>>> vswitch.
>> Pointing all virtio_net_hdr into the same memory may brings performance, but
>> how much? It also introduces difficulty to adding tso in future?
> simple rxtx will not be enabled when TSO is enabled.

Yes, I was missing simple rxtx is conflicting with 
ETH_TXQ_FLAGS_NOOFFLOADS, which indicates that simple rxtx does not want 
to fill any fields in the hdr.
Acked-by: Jianfeng Tan <jianfeng.tan@intel.com>

Thanks,
Jianfeng

>
> 	--yliu