From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 1/4] mk: add crypto capability for generic armv8a and thunderx Date: Fri, 05 May 2017 00:10:46 +0200 Message-ID: <5707863.XSAaZsHqLJ@xps> References: <20170427140618.35897-1-ashwin.sekhar@caviumnetworks.com> <20170504065702.22404-1-ashwin.sekhar@caviumnetworks.com> <20170504172022.1af906b8.viktorin@rehivetech.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Jan Viktorin , Ashwin Sekhar T K , jerin.jacob@caviumnetworks.com, jianbo.liu@linaro.org Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 18ABC7D14 for ; Fri, 5 May 2017 00:10:48 +0200 (CEST) In-Reply-To: <20170504172022.1af906b8.viktorin@rehivetech.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/05/2017 17:20, Jan Viktorin: > On Wed, 3 May 2017 23:56:59 -0700 > Ashwin Sekhar T K wrote: > > > armv8-a has optional CRYPTO extension which adds the > > AES, PMULL, SHA1 and SHA2 capabilities. -march=armv8-a+crypto > > enables code generation for the ARMv8-A architecture together > > with the optional CRYPTO extensions. > > > > added the following flags to detect the corresponding > > capability at compile time > > * RTE_MACHINE_CPUFLAG_AES > > * RTE_MACHINE_CPUFLAG_PMULL > > * RTE_MACHINE_CPUFLAG_SHA1 > > * RTE_MACHINE_CPUFLAG_SHA2 > > > > at run-time, the following flags can be used to detect these > > capabilities > > * RTE_CPUFLAG_AES > > * RTE_CPUFLAG_PMULL > > * RTE_CPUFLAG_SHA1 > > * RTE_CPUFLAG_SHA2 > > > > Signed-off-by: Ashwin Sekhar T K > > Reviewed-by: Jan Viktorin Do you agree that this series, and others bringing NEON optimizations, are not candidates for 17.05? If you see an urgent fix in all these NEON patches, please shout now. Thanks