From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 2/4] net/szedata2: use dynamically allocated
 queues
Date: Fri, 6 Apr 2018 14:51:01 +0100
Message-ID: <5711045e-de1e-82f3-8575-86bbc20c4d83@intel.com>
References: <1522849341-49049-1-git-send-email-vido@cesnet.cz>
 <1522849341-49049-3-git-send-email-vido@cesnet.cz>
 <4eac6e85-1c35-51bb-66ef-24c9a4641ab3@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: remes@netcope.com, Thomas Monjalon <thomas@monjalon.net>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 Bruce Richardson <bruce.richardson@intel.com>
To: Matej Vido <vido@cesnet.cz>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 199BA1CB26
 for <dev@dpdk.org>; Fri,  6 Apr 2018 15:51:08 +0200 (CEST)
In-Reply-To: <4eac6e85-1c35-51bb-66ef-24c9a4641ab3@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/6/2018 2:20 PM, Ferruh Yigit wrote:
> On 4/4/2018 2:42 PM, Matej Vido wrote:
>> Previously the queues were the part of private data structure of the
>> Ethernet device.
>> Now the queues are allocated at setup thus numa-aware allocation is
>> possible.
> 
> Hi Matej,
> 
> Yes by default [rt]x_queues are allocated via rte_zmalloc, which uses SOCKET_ID_ANY.
> 
> And in burst functions, we do:
>  nb_rx = (*dev->rx_pkt_burst)(dev->data->rx_queues[queue_id], rx_pkts, nb_pkts);
> 
> So there is an access to rx_queues in each rte_eth_rx_burst() call.
> 
> I wonder if you observe any performance difference with this update?
> And what about moving to the ethdev layer instead of keeping local to the PMD?

Forget about it, I thought you are allocating data->[rt]x_queues in specific
socket, but this just allocating queues in specific socket, which is OK.

Still I would like to hear comments if allocating data->[rt]x_queues arrays in
specific socket helps for performance.

> 
>>
>> Signed-off-by: Matej Vido <vido@cesnet.cz>
> 
> <...>
>