From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 01/11] eth: move queue check for
	rx_queue_count
Date: Sun, 26 Jul 2015 15:47:25 +0200
Message-ID: <5715009.9JOkuqddi2@xps13>
References: <1437757584-15502-1-git-send-email-stephen@networkplumber.org>
 <1437757584-15502-2-git-send-email-stephen@networkplumber.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com
 [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 85C82C480
 for <dev@dpdk.org>; Sun, 26 Jul 2015 15:48:41 +0200 (CEST)
Received: by wibud3 with SMTP id ud3so84251123wib.0
 for <dev@dpdk.org>; Sun, 26 Jul 2015 06:48:41 -0700 (PDT)
In-Reply-To: <1437757584-15502-2-git-send-email-stephen@networkplumber.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-07-24 10:06, Stephen Hemminger:
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -122,6 +122,7 @@
>  	}							\
>  } while (0)
>  
> +

checkpatch would warn about this whitespace change

>  static const char *MZ_RTE_ETH_DEV_DATA = "rte_eth_dev_data";
>  struct rte_eth_dev rte_eth_devices[RTE_MAX_ETHPORTS];
>  static struct rte_eth_dev_data *rte_eth_dev_data;
> @@ -2910,6 +2911,11 @@ rte_eth_rx_queue_count(uint8_t port_id, uint16_t queue_id)
>  
>  	VALID_PORTID_OR_ERR_RET(port_id, 0);
>  
> +	if (queue_id >= dev->data->nb_rx_queues) {
> +		PMD_RX_LOG(ERR, "Invalid RX queue id=%d", queue_id);
> +		return 0;
> +	}

PMD_RX_LOG is not defined in ethdev.