From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tetsuya Mukawa <mukawa@igel.co.jp>
Subject: Re: [RFC] Link ibrte_vhost to librte_pmd_vhost
Date: Tue, 26 Apr 2016 15:00:57 +0900
Message-ID: <571F0419.2060207@igel.co.jp>
References: <571DDDD8.6000000@igel.co.jp> <571DE345.4000609@redhat.com>
 <20160426034710.GD7832@yliu-dev.sh.intel.com> <571EFEA1.5080006@igel.co.jp>
 <20160426054844.GF7832@yliu-dev.sh.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: Panu Matilainen <pmatilai@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "Xie, Huawei" <huawei.xie@intel.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>
To: Yuanhan Liu <yuanhan.liu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f169.google.com (mail-pf0-f169.google.com
 [209.85.192.169]) by dpdk.org (Postfix) with ESMTP id 6B912298F
 for <dev@dpdk.org>; Tue, 26 Apr 2016 08:01:02 +0200 (CEST)
Received: by mail-pf0-f169.google.com with SMTP id c189so2641581pfb.3
 for <dev@dpdk.org>; Mon, 25 Apr 2016 23:01:02 -0700 (PDT)
In-Reply-To: <20160426054844.GF7832@yliu-dev.sh.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2016/04/26 14:48, Yuanhan Liu wrote:
> On Tue, Apr 26, 2016 at 02:37:37PM +0900, Tetsuya Mukawa wrote:
>> On 2016/04/26 12:47, Yuanhan Liu wrote:
>>> On Mon, Apr 25, 2016 at 12:28:37PM +0300, Panu Matilainen wrote:
>>>  >
>>>>> Another way is applying a below patch.
>>>>> --- a/drivers/net/vhost/Makefile
>>>>> +++ b/drivers/net/vhost/Makefile
>>>>> @@ -38,6 +38,7 @@ LIB = librte_pmd_vhost.a
>>>>>
>>>>>  CFLAGS += -O3
>>>>>  CFLAGS += $(WERROR_FLAGS)
>>>>> +LDLIBS += -lrte_vhost
>>>>>
>>>>>  EXPORT_MAP := rte_pmd_vhost_version.map
>>>>>
>>>>> This is same way to link libpcap to librte_pmd_pcap.
>>>>> What do you think about adding it to vhost PMD?
>>>> Yes, this is absolutely the right thing to do.
>>>>
>>>> Ultimately this should be done for all dependencies in all libraries, but
>>>> missing dependencies are even more pronounced in plugins so the sooner this
>>>> goes in, the better.
>>>>
>>>> Acked-by: Panu Matilainen <pmatilai@redhat.com>
>>> Panu, thanks for the input.
>>>
>>> Tetsuya, please submit a formal patch so that I can merge.
>>>
>>> 	--yliu
>> Hi Yuanhan,
>>
>> Oh sorry, I forgot to add "--in-reply-to" while sending the patch, so
>> you may miss it.
>> Also the order of Acked-by and Signed-off-by was wrong in above patch.
>> So I will send v2 soon.
> No worry. I could fix them, and I don't think there is a very strict
> rule for both of them :) BTW, FYI, I just found my linux.intel.com
> seems to be broken (no idea why), thus I made late response.
>
> (well, I found you just send a v2; I will apply that tomorrow).
>
> 	--yliu

Thank you so much!

Tetsuya