From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] eal: add missing include to debug header Date: Thu, 5 May 2016 17:07:58 +0100 Message-ID: <572B6FDE.4000209@intel.com> References: <1462379876-21901-1-git-send-email-bruce.richardson@intel.com> <20160505125942.GA14228@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Cc: thomas.monjalon@6wind.com To: Bruce Richardson , dev@dpdk.org Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id B8BC547D0 for ; Thu, 5 May 2016 18:08:01 +0200 (CEST) In-Reply-To: <20160505125942.GA14228@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/5/2016 1:59 PM, Bruce Richardson wrote: > On Wed, May 04, 2016 at 05:37:56PM +0100, Bruce Richardson wrote: >> The header file rte_debug.h makes use of the "unlikely" macro which >> means it should include the rte_branch_prediction.h header file. >> >> Fixes: 50705e8e3cdd ("eal: add assert macro for debug") >> >> Signed-off-by: Bruce Richardson >> --- >> lib/librte_eal/common/include/rte_debug.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/lib/librte_eal/common/include/rte_debug.h b/lib/librte_ea= l/common/include/rte_debug.h >> index 9260eda..cab6fb4 100644 >> --- a/lib/librte_eal/common/include/rte_debug.h >> +++ b/lib/librte_eal/common/include/rte_debug.h >> @@ -44,6 +44,7 @@ >> */ >> =20 >> #include "rte_log.h" >> +#include "rte_branch_prediction.h" >> =20 >> #ifdef __cplusplus >> extern "C" { >=20 > Ping on this patch - any comments or concerns? > It's a fairly trivial fix that prevents issues with testing some other = patches > on the mainline. >=20 Tested on top of David Marchand's 12123-12139 patchset. Acked-by: Ferruh Yigit