From mboxrd@z Thu Jan  1 00:00:00 1970
From: Remy Horton <remy.horton@intel.com>
Subject: Re: [RFC PATCH v2 1/3] rte: change xstats to use integer
 keys
Date: Wed, 18 May 2016 09:45:36 +0100
Message-ID: <573C2BB0.8000709@intel.com>
References: <1462533074-1994-1-git-send-email-remy.horton@intel.com>
 <1462533074-1994-2-git-send-email-remy.horton@intel.com>
 <1A27633A6DA49C4A92FCD5D4312DBF536B1BF2ED@IRSMSX106.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
To: "Tahhan, Maryam" <maryam.tahhan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 844945AB7
 for <dev@dpdk.org>; Wed, 18 May 2016 10:45:38 +0200 (CEST)
In-Reply-To: <1A27633A6DA49C4A92FCD5D4312DBF536B1BF2ED@IRSMSX106.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 18/05/2016 09:31, Tahhan, Maryam wrote:
[..]
>> +	eth_xstats_count_t         xstats_count;
>> +	/**< Get number of extended statistics. */
>
> Hi Remy
> While reviewing the second patch in this patchset I noticed you aren't actually using
> eth_xstats_count_t   xstats_count in the eth_dev_ops to retrieve the count in the driver.
> Do you still need xstats_count?

Well spotted - bit of dead code that slipped through the net when I 
decided to use the existing convention for the driver-side interface.

Currently working on a v3 that will convert all the drivers, so will fix 
in that patchset.

..Remy