From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Ananyev,
Konstantin"
<konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [RFC PATCH] ixgbe: ixgbe_recv_pkts_vec shouldn't override mbuf buffer length
Date: Fri, 05 Dec 2014 23:13:02 +0100 [thread overview]
Message-ID: <5741915.Ac0y19fb1f@xps13> (raw)
In-Reply-To: <5481F359.40007-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-12-05 19:03, Jean-Mickael Guerin:
> On 05/12/2014 18:07, Ananyev, Konstantin wrote:
> > From: Jean-Mickael Guerin [mailto:jean-mickael.guerin-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> >> On 05/12/2014 16:20, Konstantin Ananyev wrote:
> >>> That's an alternative way to fix the problem described in the patch:
> >>> http://dpdk.org/ml/archives/dev/2014-December/009394.html.
> >>> The main difference is:
> >>> - move buf_len fields out of rearm_data marker.
> >>> - make ixgbe_recv_pkts_vec() not touch buf_len field at all
> >>> (as all other RX functions behave).
> >>>
> >>> Signed-off-by: Konstantin Ananyev <konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> >>
> >> The patch introduces writes on unaligned data, but we can assume no
> >> performance penalty on intel hw, correct?
> >
> > Yes to both:
> > it introduces 64bit unaligned store.
> > I run performance test on IVB board, didn't see any degradation.
> > Konstantin
>
> OK fine by me:
>
> Acked-by: Jean-Mickael Guerin <jean-mickael.guerin-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Applied, even if the patch is RFC, it will be validated as part of -rc3.
Thanks
--
Thomas
prev parent reply other threads:[~2014-12-05 22:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 15:20 [RFC PATCH] ixgbe: ixgbe_recv_pkts_vec shouldn't override mbuf buffer length Konstantin Ananyev
[not found] ` <1417792834-20590-1-git-send-email-konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-05 16:59 ` Jean-Mickael Guerin
[not found] ` <5481E456.1050001-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-12-05 17:07 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB977258213BD098-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-05 18:02 ` Thomas Monjalon
2014-12-05 18:03 ` Jean-Mickael Guerin
[not found] ` <5481F359.40007-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-12-05 22:13 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5741915.Ac0y19fb1f@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).