From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [RFC PATCH] ixgbe: ixgbe_recv_pkts_vec shouldn't override mbuf buffer length Date: Fri, 05 Dec 2014 23:13:02 +0100 Message-ID: <5741915.Ac0y19fb1f@xps13> References: <1417792834-20590-1-git-send-email-konstantin.ananyev@intel.com> <2601191342CEEE43887BDE71AB977258213BD098@IRSMSX105.ger.corp.intel.com> <5481F359.40007@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Ananyev, Konstantin" Return-path: In-Reply-To: <5481F359.40007-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-12-05 19:03, Jean-Mickael Guerin: > On 05/12/2014 18:07, Ananyev, Konstantin wrote: > > From: Jean-Mickael Guerin [mailto:jean-mickael.guerin-pdR9zngts4EAvxtiuMwx3w@public.gmane.org] > >> On 05/12/2014 16:20, Konstantin Ananyev wrote: > >>> That's an alternative way to fix the problem described in the patch: > >>> http://dpdk.org/ml/archives/dev/2014-December/009394.html. > >>> The main difference is: > >>> - move buf_len fields out of rearm_data marker. > >>> - make ixgbe_recv_pkts_vec() not touch buf_len field at all > >>> (as all other RX functions behave). > >>> > >>> Signed-off-by: Konstantin Ananyev > >> > >> The patch introduces writes on unaligned data, but we can assume no > >> performance penalty on intel hw, correct? > > > > Yes to both: > > it introduces 64bit unaligned store. > > I run performance test on IVB board, didn't see any degradation. > > Konstantin > > OK fine by me: > > Acked-by: Jean-Mickael Guerin Applied, even if the patch is RFC, it will be validated as part of -rc3. Thanks -- Thomas