From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 2/2 v2] kni: Add documentation for the mempool capacity Date: Mon, 23 May 2016 18:10:36 +0100 Message-ID: <5743398C.1090504@intel.com> References: <1463815522-27916-1-git-send-email-ee07b291@gmail.com> <1463815522-27916-2-git-send-email-ee07b291@gmail.com> <57433746.5040303@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Alex Wang To: Alex Wang , dev@dpdk.org Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 4B0225901 for ; Mon, 23 May 2016 19:10:39 +0200 (CEST) In-Reply-To: <57433746.5040303@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/23/2016 6:00 PM, Ferruh Yigit wrote: > On 5/21/2016 8:25 AM, Alex Wang wrote: >> From: Alex Wang >> >> Function like 'rte_kni_rx_burst()' keeps >> allocating 'MAX_MBUF_BURST_NUM' mbufs to >> kni fifo queue unless the queue's capacity >> ('KNI_FIFO_COUNT_MAX') is reached. So, if >> the mempool is under-provisioned, user may >> run into "Out of Memory" logs from KNI code. >> This commit documents the need to provision >> mempool capacity of more than >> "2 x KNI_FIFO_COUNT_MAX" for each KNI interface. >> >> Signed-off-by: Alex Wang > > Acked-by: Ferruh Yigit > Hi Alex, This is detail but I just recognized patch subject after tag starts with uppercase. Would you mind sending another patch? You can keep my ack with it. Thanks, ferruh