From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hunt, David" Subject: Re: [dpdk-dev,v5,1/3] mempool: support external handler Date: Tue, 24 May 2016 15:04:50 +0100 Message-ID: <57445F82.9060007@intel.com> References: <1463665501-18325-2-git-send-email-david.hunt@intel.com> <20160523143511.7d30699b@pcviktorin.fit.vutbr.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, olivier.matz@6wind.com, yuanhan.liu@linux.intel.com, pmatilai@redhat.com To: Jan Viktorin Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1BAF4532C for ; Tue, 24 May 2016 16:06:29 +0200 (CEST) In-Reply-To: <20160523143511.7d30699b@pcviktorin.fit.vutbr.cz> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/23/2016 1:35 PM, Jan Viktorin wrote: > Hello David, > > please, see my comments inline. > > I didn't see the previous versions of the mempool (well, only very roughly) so I am > probably missing some points... My point of view is as a user of the handler API. > I need to understand the API to implement a custom handler for my purposes. Thanks for the review, Jan. I'm working on the changes now, will post soon. I'll reply to each of you're emails when I'm ready with the patch. Regards, David.