From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3 0/6] query hash key size in byte
Date: Thu, 09 Jul 2015 01:17:11 +0200
Message-ID: <57456880.mAaSW7tfxi@xps13>
References: <1433403216-7114-1-git-send-email-helin.zhang@intel.com>
 <1434094441-23906-1-git-send-email-helin.zhang@intel.com>
 <2601191342CEEE43887BDE71AB97725836A08EFD@irsmsx105.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Zhang, Helin" <helin.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com
 [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 9560E5921
 for <dev@dpdk.org>; Thu,  9 Jul 2015 01:18:17 +0200 (CEST)
Received: by wifm2 with SMTP id m2so2685701wif.1
 for <dev@dpdk.org>; Wed, 08 Jul 2015 16:18:17 -0700 (PDT)
In-Reply-To: <2601191342CEEE43887BDE71AB97725836A08EFD@irsmsx105.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> > As different hardware has different hash key sizes, querying it (in byte)
> > per port was asked by users. Otherwise there is no convenient way to know
> > the size of hash key which should be prepared.
> > 
> > v2 changes:
> > * Disabled the code changes by default, to avoid breaking ABI compatibility.
> > 
> > v3 changes:
> > * Moved the newly added element right after 'uint16_t reta_size', where it
> >   was a padding. So it will not break any ABI compatibility, and no need to
> >   disable the code changes by default.
> > 
> > Helin Zhang (6):
> >   ethdev: add an field for querying hash key size
> >   e1000: fill the hash key size
> >   fm10k: fill the hash key size
> >   i40e: fill the hash key size
> >   ixgbe: fill the hash key size
> >   app/testpmd: show the hash key size
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Applied, thanks

It is assumed that inserting a new field in a padding alignment won't break
the ABI.