From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH v3 13/35] mempool: store physical address in
 objects
Date: Wed, 25 May 2016 21:41:09 +0200
Message-ID: <5745FFD5.9000703@6wind.com>
References: <1460629199-32489-1-git-send-email-olivier.matz@6wind.com>
 <1463569496-31086-1-git-send-email-olivier.matz@6wind.com>
 <1463569496-31086-14-git-send-email-olivier.matz@6wind.com>
 <A09C9DDE180C7E429EC68E2BFB95C90339397519@IRSMSX107.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>,
 "stephen@networkplumber.org" <stephen@networkplumber.org>,
 "Wiles, Keith" <keith.wiles@intel.com>,
 "Griffin, John" <john.griffin@intel.com>,
 "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>,
 "Trahe, Fiona" <fiona.trahe@intel.com>,
 "Mcnamara, John" <john.mcnamara@intel.com>
To: "Jain, Deepak K" <deepak.k.jain@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 7BB1456A9
 for <dev@dpdk.org>; Wed, 25 May 2016 21:41:17 +0200 (CEST)
In-Reply-To: <A09C9DDE180C7E429EC68E2BFB95C90339397519@IRSMSX107.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Deepak,

On 05/25/2016 07:51 PM, Jain, Deepak K wrote:
> Hi,
> 
> While running the QAT PMD tests, a system hang is observed when this commit is used.
> 
> rte_mempool_virt2phy is used in qat_crypto.c.

>>From what I see in the code, the second argument of the function
rte_mempool_virt2phy(mp, elt) is not a pointer to a element of
the mempool.

This should be the case according to the API (even before my patchset):

  * @param elt
  *   A pointer (virtual address) to the element of the pool.


Could you try to replace:

  s->cd_paddr = rte_mempool_virt2phy(mp, &s->cd)

By something like:

  s->cd_paddr = rte_mempool_virt2phy(mp, s) +
    offsetof(struct qat_session, cd)



Regards,
Olivier