From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zyta Szpak Subject: Re: [PATCH 1/2] ethdev: add callback to get register size in bytes Date: Mon, 30 May 2016 11:00:27 +0200 Message-ID: <574C012B.60302@semihalf.com> References: <1462963714-21022-1-git-send-email-zr@semihalf.com> <1464158214-24733-1-git-send-email-zr@semihalf.com> <5745A544.8050505@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: thomas.monjalon@6wind.com, dev@dpdk.org To: Remy Horton Return-path: Received: from mail-lf0-f53.google.com (mail-lf0-f53.google.com [209.85.215.53]) by dpdk.org (Postfix) with ESMTP id 885D4678E for ; Mon, 30 May 2016 11:00:29 +0200 (CEST) Received: by mail-lf0-f53.google.com with SMTP id k98so69567202lfi.1 for ; Mon, 30 May 2016 02:00:29 -0700 (PDT) In-Reply-To: <5745A544.8050505@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, It is the standard DPDK return value -ENOTSUP when the function is not supported by Ethernet device. I think it is safer to keep it this way rather than default implicitly to sizeof(uint32_t) and more generic. Regards, Zyta On 25.05.2016 15:14, Remy Horton wrote: > 'noon, > > Was expecting rte_eth_dev_get_reg_width() itself to default to > sizeof(uint32_t) rather than -ENOTSUP, but that is purely personal > taste which others might disagree with. You'll also need a > documentation update & Fixes: line. > > > On 25/05/2016 07:36, zr@semihalf.com wrote: >> From: Zyta Szpak > [..] >> Signed-off-by: Zyta Szpak > > Acked-by: Remy Horton