From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] kni: fix use of undefined comma variable in
 makefile
Date: Mon, 30 May 2016 16:49:55 +0100
Message-ID: <574C6123.5090005@intel.com>
References: <1464609406-23152-1-git-send-email-olivier.matz@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: thomas.monjalon@6wind.com, helin.zhang@intel.com
To: Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 711DB2E8E
 for <dev@dpdk.org>; Mon, 30 May 2016 17:49:58 +0200 (CEST)
In-Reply-To: <1464609406-23152-1-git-send-email-olivier.matz@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/30/2016 12:56 PM, Olivier Matz wrote:
> The $(comma) variable is not defined in this Makefile, nor in
> any included Makefile. Seen while doing a "make clean" on ubuntu:
>=20
>   $ make clean
>   =3D=3D Clean lib
>   =3D=3D Clean lib/librte_compat
>   =3D=3D Clean lib/librte_eal
>   =3D=3D Clean lib/librte_eal/common
>   =3D=3D Clean lib/librte_eal/linuxapp
>   =3D=3D Clean lib/librte_eal/linuxapp/eal
>   =3D=3D Clean lib/librte_eal/linuxapp/igb_uio
>   =3D=3D Clean lib/librte_eal/linuxapp/kni
>   tr: missing operand after =E2=80=98.-=E2=80=99
>   Two strings must be given when translating.
>   Try 'tr --help' for more information.

I don't observe this error on Ubuntu.

Also did a quick check and $(comma) seems defined, but not sure exactly
where. What I test:

$ lsb_release -si
Ubuntu


$ git diff
diff --git a/lib/librte_eal/linuxapp/kni/Makefile
b/lib/librte_eal/linuxapp/kni/Makefile
index ac99d3f..dcad241 100644
--- a/lib/librte_eal/linuxapp/kni/Makefile
+++ b/lib/librte_eal/linuxapp/kni/Makefile
@@ -90,4 +90,7 @@ SRCS-y +=3D kni_net.c
 SRCS-y +=3D kni_ethtool.c
 SRCS-$(CONFIG_RTE_KNI_VHOST) +=3D kni_vhost.c

+test_comma:
+       @echo "=3D comma: $(comma) =3D"
+



$ make -C lib/librte_eal/linuxapp/kni test_comma
make: Entering directory '.../dpdk/lib/librte_eal/linuxapp/kni'
=3D comma: , =3D
make: Leaving directory '.../dpdk/lib/librte_eal/linuxapp/kni'