From mboxrd@z Thu Jan  1 00:00:00 1970
From: Zyta Szpak <zr@semihalf.com>
Subject: Re: [PATCH v2 1/2] ethdev: add callback to get register
 size in bytes
Date: Tue, 31 May 2016 17:08:39 +0200
Message-ID: <574DA8F7.7020205@semihalf.com>
References: <1464601185-7330-1-git-send-email-zr@semihalf.com>
 <89305686-998b-9f36-d2c2-dc6ec123c5c5@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Panu Matilainen <pmatilai@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f43.google.com (mail-lf0-f43.google.com
 [209.85.215.43]) by dpdk.org (Postfix) with ESMTP id 666182C7A
 for <dev@dpdk.org>; Tue, 31 May 2016 17:08:40 +0200 (CEST)
Received: by mail-lf0-f43.google.com with SMTP id w16so80462773lfd.2
 for <dev@dpdk.org>; Tue, 31 May 2016 08:08:40 -0700 (PDT)
In-Reply-To: <89305686-998b-9f36-d2c2-dc6ec123c5c5@redhat.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 30.05.2016 12:58, Panu Matilainen wrote:
> On 05/30/2016 12:39 PM, zr@semihalf.com wrote:
>> From: Zyta Szpak <zr@semihalf.com>
>>
>> Version 2 of fixing the fixed register width assumption.
>> rte_eth_dev_get_reg_length and rte_eth_dev_get_reg callbacks
>> do not provide register size to the app in any way. It is
>> needed to allocate proper number of bytes before retrieving
>> registers content with rte_eth_dev_get_reg.
>>
>> Signed-off-by: Zyta Szpak <zr@semihalf.com>
> [...]
>> diff --git a/lib/librte_ether/rte_ether_version.map 
>> b/lib/librte_ether/rte_ether_version.map
>> index 214ecc7..288bc63 100644
>> --- a/lib/librte_ether/rte_ether_version.map
>> +++ b/lib/librte_ether/rte_ether_version.map
>> @@ -130,5 +130,6 @@ DPDK_16.04 {
>>      rte_eth_tx_buffer_drop_callback;
>>      rte_eth_tx_buffer_init;
>>      rte_eth_tx_buffer_set_err_callback;
>> +    rte_eth_dev_get_reg_width;
>>
>>  } DPDK_2.2;
>
> This symbol did not exist in DPDK 16.04 so it must not be added there. 
> Add a new section for 16.07 which inherits from DPDK_16.04.
>
>     - Panu -
>
Right.