From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [PATCH] kni: fix use of undefined comma variable in
 makefile
Date: Tue, 31 May 2016 21:12:43 +0200
Message-ID: <574DE22B.1010209@6wind.com>
References: <1464609406-23152-1-git-send-email-olivier.matz@6wind.com>
 <574C6123.5090005@intel.com> <574C68A1.2090408@6wind.com>
 <574C6E71.3090601@intel.com> <574D933C.2080507@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: thomas.monjalon@6wind.com, helin.zhang@intel.com
To: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id DBEA8379B
 for <dev@dpdk.org>; Tue, 31 May 2016 21:12:45 +0200 (CEST)
Received: by mail-wm0-f42.google.com with SMTP id s131so24155206wme.0
 for <dev@dpdk.org>; Tue, 31 May 2016 12:12:45 -0700 (PDT)
In-Reply-To: <574D933C.2080507@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Ferruh,

On 05/31/2016 03:35 PM, Ferruh Yigit wrote:
> Error is related to the kernel version, in second call "comma"
> definition comes from kernel makefiles.
> 
> Following commit causes comma to be defined:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=371fdc77af44f4cb32475fd499e1d912ccc30890
> 
> So this is valid issue for old kernels, and using "," directly looks OK.
> 
>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> Acked-by Ferruh Yigit <ferruh.yigit@intel.com>

Thanks for investigating the issue!
Olivier