From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v7 2/3] doc: change type of return value of adding MAC addr Date: Fri, 05 May 2017 16:23:03 +0200 Message-ID: <5751614.JobCQIIaUB@xps> References: <1493729065-17090-1-git-send-email-wei.dai@intel.com> <1493944802-52943-1-git-send-email-wei.dai@intel.com> <1493944802-52943-3-git-send-email-wei.dai@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, wenzhuo.lu@intel.com, harish.patil@cavium.com, rasesh.mody@cavium.com, stephen.hurd@broadcom.com, ajit.khaparde@broadcom.com, helin.zhang@intel.com, konstantin.ananyev@intel.com, jingjing.wu@intel.com, jing.d.chen@intel.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com, bruce.richardson@intel.com, yuanhan.liu@linux.intel.com, maxime.coquelin@redhat.com, shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com, john.miller@atomicrules.com To: Wei Dai Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 91C1E2986 for ; Fri, 5 May 2017 16:23:04 +0200 (CEST) In-Reply-To: <1493944802-52943-3-git-send-email-wei.dai@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/05/2017 02:40, Wei Dai: > Add following lines in section of API change in release note. > > If a MAC address fails to be added without this change, it is still > stored and may be regarded as a valid one. This may lead to errors > in application. The type of return value of eth_mac_addr_add_t in > rte_ethdev.h is changed. Any specific NIC also follows this change. > > Signed-off-by: Wei Dai > Acked-by: John McNamara This patch is rejected because it is neither an API nor an ABI change.