From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ethdev: fix iterator default behaviour for representors Date: Wed, 24 Oct 2018 15:19:45 +0200 Message-ID: <5755587.GAzGENloro@xps> References: <20181024131321.8409-1-thomas@monjalon.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Andrew Rybchenko , ophirmu@mellanox.com To: Ferruh Yigit Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C57AB5681 for ; Wed, 24 Oct 2018 15:19:42 +0200 (CEST) In-Reply-To: <20181024131321.8409-1-thomas@monjalon.net> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/10/2018 15:13, Thomas Monjalon: > The iterator was matching all representors if it was not specified > in the devargs string. It was a wrong default behaviour. > > If there is no representor parameter in the devargs, the iterator > should not match any representor port. > > The implementation of the default behaviour would be simpler > if a "no match" handler is added to rte_kvargs_process(). > As it requires an API breakage, it will be reworked later. > > Signed-off-by: Thomas Monjalon It is fixing the commit "support representor id as iterator filter" which is in dpdk-next-net tree. I think we should not squash them. It is fine to have both patches separated with a clear explanation. When the first commit will be in mainline, we could add a Fixes: tag to this patch.