From mboxrd@z Thu Jan 1 00:00:00 1970 From: Remy Horton Subject: Re: [PATCH v3 1/2] ethdev: add callback to get register size in bytes Date: Mon, 13 Jun 2016 16:51:02 +0100 Message-ID: <575ED666.2010509@intel.com> References: <1464767771-19159-1-git-send-email-zr@semihalf.com> <12994980.C5dFrG15Qg@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Zyta Szpak , Thomas Monjalon Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id EFAF7558D for ; Mon, 13 Jun 2016 17:51:04 +0200 (CEST) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/06/2016 15:51, Zyta Szpak wrote: > I would prefer having only one function rte_eth_dev_get_regs() > which returns length and width if data is NULL. > The first call is a parameter request before buffer allocation, > and the second call fills the buffer. > > We can deprecate the old API and introduce this new one. > > Opinions? > > In my opinion as it is now it works fine. Gathering all parameters in > one callback might be a good idea if the maintainer also agrees to that > because as I mentioned, it interferes. From my perspective changing rte_eth_dev_get_regs() isn't a problem, as it isn't used directly rather than through rte_ethtool_get_regs().. ..Remy