From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v5 02/38] bnxt: add HWRM init code
Date: Wed, 15 Jun 2016 17:25:44 +0100
Message-ID: <57618188.8090804@intel.com>
References: <1465250923-78695-1-git-send-email-stephen.hurd@broadcom.com>
 <1465944971-113413-1-git-send-email-stephen.hurd@broadcom.com>
 <1465944971-113413-2-git-send-email-stephen.hurd@broadcom.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
To: Stephen Hurd <stephen.hurd@broadcom.com>, dev@dpdk.org,
 ajit.khaparde@broadcom.com, bruce.richardson@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id D2B88C58E
 for <dev@dpdk.org>; Wed, 15 Jun 2016 18:25:47 +0200 (CEST)
In-Reply-To: <1465944971-113413-2-git-send-email-stephen.hurd@broadcom.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/14/2016 11:55 PM, Stephen Hurd wrote:
> From: Ajit Khaparde <ajit.khaparde@broadcom.com>
>=20
> Start adding support to use the HWRM API.
> Hardware Resource Manager or HWRM in short, is a set of API provided
> by the firmware running in the ASIC to manage the various resources.
>=20
> Initial commit just performs necessary HWRM queries for init, then
> fails as before.
>=20
> Now that struct bnxt is non-zero size, we can set dev_private_size
> correctly.
>=20
> The used HWRM calls so far:
> bnxt_hwrm_func_qcaps:
> 	This command returns capabilities of a function.
>=20
> bnxt_hwrm_ver_get:
> 	This function is called by a driver to determine the HWRM
> 	interface version supported by the HWRM firmware, the
> 	version of HWRM firmware implementation, the name of HWRM
> 	firmware, the versions of other embedded firmwares, and
> 	the names of other embedded firmwares, etc.  Gets the
> 	firmware version and interface specifications.  Returns
> 	an error if the firmware on the device is not supported
> 	by the driver and ensures the response space is large
> 	enough for the largest possible response.
>=20
> bnxt_hwrm_queue_qportcfg:
> 	This function is called by a driver to query queue
> 	configuration of a port.
>=20
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Signed-off-by: Stephen Hurd <stephen.hurd@broadcom.com>
> Reviewed-by: David Christensen <david.christensen@broadcom.com>
>=20
> --
> v4:
> Fix few issues highlighted by checkpatch.
>=20
> v5:
> Fix footer formatting
> Switch to using the HWRM function descriptions from the source
> documentation
> ---

Hi Stephen,

I run basic checks on the patch set, mainly it compiles and applies
fine, overall patch set looks good.

Only get following checkpatch warning:
Only v5,02/38 has one WARNING:MACRO_WITH_FLOW_CONTROL

And my script caught following typos on commit messages:
v5-07-38: mamagement
v5-12-38: staitstics, asociated
v5-14-38: fo
v5-25-38: cleansup
v5-28-38: arugments
v5-30-38: wraper

If there won't be a new version of patch set, perhaps we can ask Bruce
to fix typos when applying J

Thanks,
ferruh